transition() mixin prevent redundant 'transition: none' and pass null
#30391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found a problem, please don't review yet. |
|
OK, ready for review. |
ysds
changed the title
null
MartijnCuppens
approved these changes
Mar 14, 2020
|
Any reason we don't land this in v5? |
MartijnCuppens
added a commit
that referenced
this pull request
Apr 6, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Apr 7, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Apr 10, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Apr 13, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
…l` (twbs#30391) * Prevent redundant 'none' for prefers-reduced-motion * Output warning when use 'none' or 'null' with multiple arguments * Fix for libsass(node-sass)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes three points:
1.
transition(null)andtransition(none)output the following redundant CSS, but should be prevented.2. Fix the problem where libsass(node-sass) can't handle
transition(null)well:selector { @include transition(null); } // output selector { transition:; }3. The transition mixin now show warning message when use
noneornullwith multiple arguments.Before: https://www.sassmeister.com/gist/b4d2d3ce8601116308e72df97a0d309a
After: https://www.sassmeister.com/gist/7ddae4ab995e0b41bbb93abe6eff616f